Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add interpolate function and test #26226

Closed
wants to merge 11 commits into from
Closed

feat: add interpolate function and test #26226

wants to merge 11 commits into from

Conversation

rfatihors
Copy link

@rfatihors rfatihors commented Sep 27, 2023 •
edited
Loading

feat: add interpolate function and test

Related Issue

Add Layers to Paddle Backend
#10696
add interpolate function and test

Close #26133

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

github-actions[bot]
github-actions bot reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@ivy-leaves ivy-leaves added the PaddlePaddle Backend Developing the Paddle Paddle Backend. label Sep 27, 2023
github-actions[bot]
github-actions bot reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord

Here are some notes to understand our tests:

  • We have merged all the tests in one file called `display_test_results` job. 👀 It contains the following two sections:
    • Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
    • New Failures Introduced: This lists the tests that fails on this PR.

Please make sure they are passing. 💪

Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, kindly be patient 😄.

@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@rfatihors rfatihors mentioned this pull request Sep 27, 2023
Open
@rfatihors rfatihors mentioned this pull request Sep 28, 2023
Open
@danielmunioz
Copy link
Contributor

Hey @rfatihors! Thanks for contributing! 🚀

Looks like the test for your function is missing, also it seems you're implementing it on the regular paddle backend? This one is an Experimental Function, as such it needs to be placed on the experimental paddle folder!
Please take a look at the Experimental Functions Guide for more info on how to align your implementation with Ivy!

If you have any questions whatsoever please don't hesitate to ask!
Thanks :)

@rfatihors
Copy link
Author

rfatihors commented Oct 1, 2023 via email •
edited
Loading

@rfatihors
Copy link
Author

Hi, I made the changes that were requested. Please, kindly take a look and re-review.

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023 •
edited
Loading

Thank you for this PR, here is the CI results:

Failed tests:

This PR introduces the following new failing tests:
ivy_tests/test_ivy/test_functional/test_experimental/test_core/test_elementwise.py::test_amax,torch
ivy_tests/test_ivy/test_functional/test_experimental/test_core/test_elementwise.py::test_amax,jax
ivy_tests/test_ivy/test_functional/test_experimental/test_core/test_elementwise.py::test_amax,numpy

@danielmunioz
Copy link
Contributor

Hey @rfatihors!

Yeah some of the changes look good! however it seems that you are introducing changes to the .idea folder, could you please remove those?
As well as a new Tensor class being added to the paddle/__init__.py file? May I ask why did you add that? As per ivy rules, the PR should only contain changes related to the issue at hand, so could you please remove that new class?.

Thanks!

@danielmunioz danielmunioz removed the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Oct 5, 2023
@rfatihors
Copy link
Author

Hi again, I reverted the changes that you mentioned. At late night, I was trying the understand the structure and if I could see the variables for a better understanding of the whole of tests. Then, I guess in the morning forgot to delete, sorry.

@rfatihors rfatihors changed the title interpolate #26133 issue feat: interpolate #26133 issue Oct 12, 2023
@rfatihors rfatihors changed the title feat: interpolate #26133 issue feat: add interpolate function and test #26133 issue Oct 12, 2023
@rfatihors rfatihors changed the title feat: add interpolate function and test #26133 issue feat: add interpolate function and test Oct 12, 2023
@ivy-seed
Copy link

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@ivy-seed ivy-seed added the Stale label Feb 25, 2024
@ivy-seed
Copy link

ivy-seed commented Mar 3, 2024

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

@ivy-seed ivy-seed closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Aarsh2001 Aarsh2001 Awaiting requested review from Aarsh2001

Assignees

@Ishticode Ishticode

Labels
Paddle Paddle Backend PaddlePaddle Backend Developing the Paddle Paddle Backend. Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

interpolate
6 participants
@rfatihors @ivy-leaves @danielmunioz @ivy-seed @Ishticode @ivy-branch